Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error on timeout (bugfix) #1302

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Return error on timeout (bugfix) #1302

merged 1 commit into from
Jun 20, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jun 20, 2024

Description

If checkbox times out connecting to the agent, it prints an error but exists with return code 0. This is an issue because we can't rely on $? in this situation (like our canary pipeline does) and it clearly a bug. This fixes said bug.

Resolved issues

Fixes: CHECKBOX-1468

Documentation

N/A

Tests

This adds a test for the "new" situation

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.17%. Comparing base (b29ac00) to head (cb0a671).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
+ Coverage   44.16%   44.17%   +0.01%     
==========================================
  Files         359      359              
  Lines       38812    38812              
  Branches     6581     6581              
==========================================
+ Hits        17141    17147       +6     
+ Misses      21007    21003       -4     
+ Partials      664      662       -2     
Flag Coverage Δ
checkbox-ng 67.59% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-gentili p-gentili merged commit 8a9c908 into main Jun 20, 2024
20 checks passed
@p-gentili p-gentili deleted the err_on_timeout branch June 20, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants