Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded strings (BugFix) #1370

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix hardcoded strings (BugFix) #1370

merged 1 commit into from
Jul 26, 2024

Conversation

baconYao
Copy link
Contributor

@baconYao baconYao commented Jul 26, 2024

Description

Recently, some SRU testings report a problem about dpkg-query: no packages found matching ubuntu-desktop

This is caused by a hardcoded string, ubuntu-desktop, in the script. It leads some devices have ubuntu-desktop-minimal package run into wrong checking target.

Resolved issues

Documentation

Tests

Sideload Test on Baoshan G510 (Desktop Image 03_19 version)

@baconYao baconYao marked this pull request as ready for review July 26, 2024 01:59
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.12%. Comparing base (0e188c6) to head (cb4a402).
Report is 124 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files         366      366           
  Lines       39058    39058           
  Branches     6607     6607           
=======================================
  Hits        17626    17626           
  Misses      20758    20758           
  Partials      674      674           
Flag Coverage Δ
provider-base 18.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, ty for finding this issue

@Hook25 Hook25 merged commit d3cc38e into main Jul 26, 2024
42 checks passed
@Hook25 Hook25 deleted the fix-ubuntu-desktop-minimal branch July 26, 2024 07:27
pedro-avalos pushed a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants