Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual encryption job from automated UC24 test plan (Bugfix) #1376

Merged

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Jul 30, 2024

disk/encryption/check-fde-tpm is a manual test. Including it in an automated test plan blocks the automated execution of this test plan in Jenkins, and leads to time outs when running this in the Cert lab.

Description

Resolved issues

https://chat.canonical.com/canonical/pl/37q5cow3aprr3fi4ypawnotg5r

Documentation

Tests

disk/encryption/check-fde-tpm is a manual test. Including it in an
automated test plan blocks the automated execution of this test plan in
Jenkins, and leads to time outs when running this in the Cert lab.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.12%. Comparing base (9639ba7) to head (fa0593e).
Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files         366      366           
  Lines       39058    39058           
  Branches     6607     6607           
=======================================
  Hits        17626    17626           
  Misses      20758    20758           
  Partials      674      674           
Flag Coverage Δ
provider-certification-client 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for proposing this fix

@Hook25 Hook25 merged commit 7ab7c0f into main Jul 30, 2024
40 checks passed
@Hook25 Hook25 deleted the remove-manual-encryption-test-from-uc24-automated-test-plan branch July 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants