Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate SRU with clear warning in the description (Infra) #1380

Merged
merged 12 commits into from
Aug 7, 2024
Merged

Gate SRU with clear warning in the description (Infra) #1380

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
446305c
Initial workflow implementation
Hook25 Jul 30, 2024
9670cc0
Remove ready for review state
Hook25 Jul 30, 2024
26bc31d
Add sudo apt
Hook25 Jul 30, 2024
d0dd468
libsystemd-dev :(
Hook25 Jul 30, 2024
e1d74e6
No need to build provider in order to read them
Hook25 Jul 30, 2024
2bb4123
Typo certification
Hook25 Jul 30, 2024
8910f7c
Missing extensions and provider
Hook25 Jul 30, 2024
cd61e1f
Missing square bracket
Hook25 Jul 30, 2024
95df047
Fetch the actual PR description
Hook25 Jul 30, 2024
40ec5c3
Better message log for the action
Hook25 Jul 30, 2024
6fca1d7
Explain the jq gibberish
Hook25 Aug 7, 2024
eede56e
Better wording from pieq
Hook25 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/pr_validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,19 @@ jobs:
echo
echo
echo "Difference of com.canonical.certification::sru-server (diff this_branch main)"
# the following line sorts the array of jobs/templates obtained from the pre/post checkout
# this is done because we want compare the list/content of jobs but not necessarely the order
# that for most jobs is not deterministic either way. The array keys are sorted as well
# as what counts is the content of each key (id, environ, command) and not the order
# the exporter prints them out
Hook25 marked this conversation as resolved.
Show resolved Hide resolved
# Taken partially from: https://github.com/jqlang/jq/issues/893
diff \
<(jq -S 'def post_recurse(f): def r: (f | select(. != null) | r), .; r; def post_recurse: post_recurse(.[]?); (. | (post_recurse | arrays) |= sort)' "sru_server_testplan_this_branch.json") \
Hook25 marked this conversation as resolved.
Show resolved Hide resolved
<(jq -S 'def post_recurse(f): def r: (f | select(. != null) | r), .; r; def post_recurse: post_recurse(.[]?); (. | (post_recurse | arrays) |= sort)' "sru_server_testplan_main.json") | tee sru_server_diff.txt

if [ -s sru_server_diff.txt ]; then
# if the sru_server_diff file is not empty, there is at least one diff (patch) done to it
# require the PR description to contain the bold text highlighting it
if [[ "$DESCRIPTION" == *"## WARNING: This modifies com.canonical.certification::sru-server"* ]]; then
echo "Warning is correcty posted in the description for sru-server"
else
Expand All @@ -82,11 +90,19 @@ jobs:
fi

echo "Difference of com.canonical.certification::sru (diff this_branch main)"
# the following line sorts the array of jobs/templates obtained from the pre/post checkout
# this is done because we want compare the list/content of jobs but not necessarely the order
# that for most jobs is not deterministic either way. The array keys are sorted as well
# as what counts is the content of each key (id, environ, command) and not the order
# the exporter prints them out
# Taken partially from: https://github.com/jqlang/jq/issues/893
diff \
<(jq -S 'def post_recurse(f): def r: (f | select(. != null) | r), .; r; def post_recurse: post_recurse(.[]?); (. | (post_recurse | arrays) |= sort)' "sru_testplan_this_branch.json") \
<(jq -S 'def post_recurse(f): def r: (f | select(. != null) | r), .; r; def post_recurse: post_recurse(.[]?); (. | (post_recurse | arrays) |= sort)' "sru_testplan_main.json") | tee sru_diff.txt

if [ -s sru_diff.txt ]; then
# if the sru_server_diff file is not empty, there is at least one diff (patch) done to it
# require the PR description to contain the bold text highlighting it
if [[ "$DESCRIPTION" == *"## WARNING: This modifies com.canonical.certification::sru"* ]]; then
echo "Warning is correcty posted in the description for sru"
else
Expand Down