-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parser to parse wifi interface name which is not start with phy (BugFix) #1390
Conversation
a648eac
to
3b6473a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 45.72% 45.76% +0.04%
==========================================
Files 367 368 +1
Lines 39134 39171 +37
Branches 6618 6625 +7
==========================================
+ Hits 17894 17928 +34
- Misses 20565 20567 +2
- Partials 675 676 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bc0f2d2
to
e4fd5a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very weird resource. Why is the name of the interface a part of the resource attributes? How is this used? What happens if a mode is not supported?
Implementation feedback: you should use dicts for interface id mapping, so that you can go from one to the other without doing a full iteration over all interfaces!
Note: dont be scared by the huge diff of my suggestions, Github basically gives up at calculating a diff if you chanage indentation
Co-authored-by: Massimiliano <[email protected]>
ec1aff1
to
da10daf
Compare
da10daf
to
223e4ff
Compare
@Hook25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Well done, +1
Description
Add a parser to parse out the phy name as follows:
phy name start with phy.
phy name start with other string.
Please refer to this PR for previous discussion.
Resolved issues
This change is trying to fix the issue
Documentation
Tests
Side load result of IoT Arm64 with 2 wlan interfaces on UC22
Side load result of IoT Arm64 with one wlan interface on UC20
Side load result of Desktop AMD64 with one wlan interface on 24.04
Side load result of Desktop AMD64 with one wlan interface on 22.04