Make all rtcwake cmd can select the RTC_DEVICE_FILE from config file (New) #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankingyang
requested review from
pieqq,
LiaoU3 and
stanley31huang
and removed request for
pieqq and
LiaoU3
seankingyang
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 45.12% 45.13% +0.01%
==========================================
Files 366 366
Lines 39058 39063 +5
Branches 6607 6608 +1
==========================================
+ Hits 17626 17633 +7
+ Misses 20758 20756 -2
Partials 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seankingyang
changed the title
zongminl
removed request for
pieqq,
stanley31huang,
zongminl,
LiaoU3 and
baconYao
zongminl
requested changes
Aug 7, 2024
|
I am wondering if there are multiple RTC like rtc1, how should we handle it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WARNING: This modifies com.canonical.certification::sru-server
Modify all jobs will call the rtcwake cmd and didn't support for user to select which rtc device they want to use.
In rtcwake default will use the
rtc0, and this change will also make if theRTC_DEVICE_FILEdidn't define in config will also use thertc0.Resolved issues
Documentation
OEMQA-4726 Modify jobs' command will call the rtcwake can support user to select which RTC devcie
Tests