Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing CPUID for cpuid turin (bugfix) #1397

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fixed missing CPUID for cpuid turin (bugfix) #1397

merged 1 commit into from
Aug 7, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Aug 7, 2024

Description

Adds the missing cpu id and also prints out missing ones so that next time it will be easier to determine what is missing (just form the printed out error)

Resolved issues

Fixes: CHECKBOX-1520
Fixes: #1384

Documentation

N/A

Tests

N/A

Minor: Fix bug, print the id string, not the object, so that it is easier to fetch
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (904692d) to head (1fc2d5b).
Report is 118 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         366      366           
  Lines       39102    39102           
  Branches     6609     6609           
=======================================
  Hits        17669    17669           
  Misses      20760    20760           
  Partials      673      673           
Flag Coverage Δ
provider-base 18.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@pieqq pieqq merged commit 17d2d8c into main Aug 7, 2024
42 checks passed
@pieqq pieqq deleted the amd_turin_cpuid branch August 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new CPUID of AMD Turin to cpuid.py
2 participants