-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gtk from camera multiple resolutions (New) #1400
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
+ Coverage 45.87% 47.29% +1.42%
==========================================
Files 367 367
Lines 39156 39490 +334
Branches 6622 6671 +49
==========================================
+ Hits 17961 18678 +717
+ Misses 20504 20099 -405
- Partials 691 713 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I really like the changes here (especially the renames!). I have a few comments here and there
87f88ab
to
1cf61c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm for doing this. Super cool, +1
Description
The main objective of this test was to remove Clutter and Gtk dependencies from
camera_test.py
so we could run themultipe-resolution-images
job on core devices without a display. The testing on the available core devices with camera required some additional fixes to the script, So this PR contains a bigger series of changes.:fswebcam
capture has been isolated so it can be removed in the future if we consider.Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1200
Documentation
The camera test script has been documented further inside the code adding more clear comments
Tests
To test this new script on a device, you can run any of the automated or manual camera tests:
submission_2024-08-08T14.05.34.803516.zip
Note:
On shiner-imx8-med-pdk001, gstreamer is not able to capture the image at 1640x1232, so the test times out. If that resolution is excluded, the test passes.
With 1640x1232 excluded: