Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter suspend by 'systemctl suspend' in suspend.sh (Bugfix) #1413

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Aug 12, 2024

Description

systemctl suspend is the way that user enter suspend mode regularly. Besides, this is also to align with suspend/suspend_advanced_auto
Moreover, with this change, some devices that does not support enter suspend via rtc can now run suspend-cycles-stress-test.

Resolved issues

  1. To enter suspend as the way that regular user does.
  2. Fix the default config variable from rtc0 to /dev/rtc0

Documentation

N/A

Tests

https://certification.canonical.com/hardware/202406-34151/submission/386064/

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (dfae162) to head (da4f796).
Report is 116 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1413   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files         366      366           
  Lines       39107    39107           
  Branches     6612     6612           
=======================================
  Hits        17670    17670           
  Misses      20764    20764           
  Partials      673      673           
Flag Coverage Δ
provider-base 18.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiaoU3 LiaoU3 changed the title Enter suspend via 'systemctl suspend' in suspend.sh (Bugfix) Enter suspend by 'systemctl suspend' in suspend.sh (Bugfix) Aug 12, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, makes sense. Makes me wonder, are there situations where rtcwake can suspend and systemctl no?

@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Aug 12, 2024

@Hook25 I've never met the situation you describe before. I only have devices that can enter suspend by systemctl suspend, but not rtcwake

@LiaoU3 LiaoU3 merged commit ce1e91a into main Aug 12, 2024
45 checks passed
@LiaoU3 LiaoU3 deleted the suspend_stress branch August 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants