-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from mobilebroadband to wwan nested parts for cert test plans (bugfix) #1496
Conversation
Following QA changes in #821¹ regarding the replacement of mobilebroadband-cert-.* nested part for their wwan-.* counterparts, the same is applied for: - client-cert-desktop-24-04 (it was missed in #821 due to bad timing) - client-cert-odm-desktop-2?-04 (to match what's being tested by the QA team) client-cert-odm-desktop-18-04 was not included due to the fact that Ubuntu 18.04 has seen EOL and therefore its related test plan is not actively maintained anymore. ¹ #821
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 369 369
Lines 39586 39586
Branches 6685 6685
=======================================
Hits 18798 18798
Misses 20077 20077
Partials 711 711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jocave I noticed a lot of the I still decided to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline comments.
providers/certification-client/units/client-cert-odm-desktop-20-04.pxu
Outdated
Show resolved
Hide resolved
providers/certification-client/units/client-cert-odm-desktop-22-04.pxu
Outdated
Show resolved
Hide resolved
These nested parts have nothing to do here.
Thanks, I messed up something when batch-editing the test plans! The new pushed version should be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you
wwan/detect-manual and wwan/check-sim-present-manual have an automated version available. wwan/gsm-connection-interrupted-manual depends on the manual versions of the detection and SIM verification jobs, and is therefore removed as well, as we have an automated connection job.
LGTM +1, thanks for the correction |
Description
Following QA changes in #821 regarding the replacement of
mobilebroadband-cert-.*
nested parts for theirwwan-.*
counterparts, the same is applied for:client-cert-desktop-24-04
(it was missed in Adjust the wwan, watchdog and alsa-loopback test cases. (BugFix) #821 due to bad timing)client-cert-odm-desktop-2?-04
(to match what's being tested by the QA team)client-cert-odm-desktop-18-04
was not included due to the fact that Ubuntu 18.04 has seen EOL and therefore its related test plan is not actively maintained anymore.Resolved issues
Documentation
Tests