Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from mobilebroadband to wwan nested parts for cert test plans (bugfix) #1496

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Sep 23, 2024

Description

Following QA changes in #821 regarding the replacement of mobilebroadband-cert-.* nested parts for their wwan-.* counterparts, the same is applied for:

client-cert-odm-desktop-18-04 was not included due to the fact that Ubuntu 18.04 has seen EOL and therefore its related test plan is not actively maintained anymore.

Resolved issues

Documentation

Tests

Following QA changes in #821¹ regarding the replacement of
mobilebroadband-cert-.* nested part for their wwan-.* counterparts, the
same is applied for:

- client-cert-desktop-24-04 (it was missed in #821 due to bad timing)
- client-cert-odm-desktop-2?-04 (to match what's being tested by the QA
team)

client-cert-odm-desktop-18-04 was not included due to the fact that
Ubuntu 18.04 has seen EOL and therefore its related test plan is not
actively maintained anymore.

¹ #821
@pieqq pieqq requested a review from jocave September 23, 2024 07:04
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.48%. Comparing base (104c931) to head (833eeab).
Report is 118 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1496   +/-   ##
=======================================
  Coverage   47.48%   47.48%           
=======================================
  Files         369      369           
  Lines       39586    39586           
  Branches     6685     6685           
=======================================
  Hits        18798    18798           
  Misses      20077    20077           
  Partials      711      711           
Flag Coverage Δ
provider-base 24.02% <ø> (ø)
provider-certification-client 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pieqq
Copy link
Collaborator Author

pieqq commented Sep 23, 2024

@jocave I noticed a lot of the after-suspend-.*-automated parts had been commented out in 42d8e01, but I'm not sure why. This was done for 20.04 and then propagated to 22.04 and 24.04.

I still decided to include after-suspend-wwan-automated nested part is it is used in the client-desktop test plan, but I will need your feedback on this.

Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comments.

These nested parts have nothing to do here.
@pieqq
Copy link
Collaborator Author

pieqq commented Sep 23, 2024

Please see my inline comments.

Thanks, I messed up something when batch-editing the test plans!

The new pushed version should be better.

zongminl
zongminl previously approved these changes Sep 24, 2024
Copy link
Collaborator

@zongminl zongminl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you

wwan/detect-manual and wwan/check-sim-present-manual have an automated
version available. wwan/gsm-connection-interrupted-manual depends on the
manual versions of the detection and SIM verification jobs, and is
therefore removed as well, as we have an automated connection job.
@seankingyang
Copy link
Contributor

LGTM +1, thanks for the correction

@pieqq pieqq dismissed seankingyang’s stale review September 24, 2024 13:20

Isaac +1ed later on

@pieqq pieqq merged commit 7182b16 into main Sep 24, 2024
47 checks passed
@pieqq pieqq deleted the switch-to-wwan-nested-part-24-04 branch September 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants