-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest for pdu cold reboot related jobs (Bugfix) #1665
Conversation
To prevent the job from being executed unintentionally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 372 372
Lines 40321 40321
Branches 6811 6811
=======================================
Hits 19757 19757
Misses 19842 19842
Partials 722 722 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the change!
With this change, does it mean that we could include ce-oem-power-automated-by-pdu in our stress test plan? If yes, could you do it as well in this PR?
I've add that plan into automated plan since that is an automated test. However, the stress plan(ce-oem-cold-boot-stress-test-by-pdu) included already. Many thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant!
Description
Add a manifest entry for the PDU cold reboot-related job. However, this is a short-term solution to prevent the job from being executed unintentionally. In the long term, such jobs should depend on the platform's capability to wake from RTC.
Resolved issues
Documentation
Tests
https://certification.canonical.com/hardware/202408-34281/submission/406720/test-results/
https://certification.canonical.com/hardware/202408-34281/submission/406719/test-results/