Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest for pdu cold reboot related jobs (Bugfix) #1665

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

rickwu666666
Copy link
Contributor

Description

Add a manifest entry for the PDU cold reboot-related job. However, this is a short-term solution to prevent the job from being executed unintentionally. In the long term, such jobs should depend on the platform's capability to wake from RTC.

Resolved issues

Documentation

Tests

https://certification.canonical.com/hardware/202408-34281/submission/406720/test-results/
https://certification.canonical.com/hardware/202408-34281/submission/406719/test-results/

To prevent the job from being executed unintentionally.
@rickwu666666 rickwu666666 changed the title Add manifest for pdu cold reboot related jobs Add manifest for pdu cold reboot related jobs (Bugfix) Dec 20, 2024
@rickwu666666 rickwu666666 added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (4305ba1) to head (6d550f1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1665   +/-   ##
=======================================
  Coverage   48.99%   48.99%           
=======================================
  Files         372      372           
  Lines       40321    40321           
  Branches     6811     6811           
=======================================
  Hits        19757    19757           
  Misses      19842    19842           
  Partials      722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the change!
With this change, does it mean that we could include ce-oem-power-automated-by-pdu in our stress test plan? If yes, could you do it as well in this PR?

@rickwu666666
Copy link
Contributor Author

I love the change! With this change, does it mean that we could include ce-oem-power-automated-by-pdu in our stress test plan? If yes, could you do it as well in this PR?

I've add that plan into automated plan since that is an automated test. However, the stress plan(ce-oem-cold-boot-stress-test-by-pdu) included already. Many thanks for the review.

@rickwu666666 rickwu666666 requested a review from LiaoU3 December 25, 2024 06:36
Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@rickwu666666 rickwu666666 merged commit 23de911 into main Dec 25, 2024
10 checks passed
@rickwu666666 rickwu666666 deleted the add-manifest-for-pdu-cold-boot branch December 25, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants