Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox-ce-oem] Enhance serial test to be more stable (Bugfix) #1682

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

hanhsuan
Copy link
Contributor

Description

  1. The server mode shouldn't be exited while getting the payload that couldn't be decoded.
  2. The client mode should clean the buffer before starting the test to avoid receiving non testing payload.

Resolved issues

Documentation

Tests

https://certification.canonical.com/hardware/202405-34046/submission/408239/

@hanhsuan hanhsuan added the ce-oem The PR only contains to the ce-oem provider under the contrib area label Jan 15, 2025
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the patch.

Copy link
Contributor

@LiaoU3 LiaoU3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@hanhsuan hanhsuan marked this pull request as draft January 15, 2025 03:29
@hanhsuan
Copy link
Contributor Author

@rickwu666666 mention the client mode couldn't work on his side, let's check it before merging.

@rickwu666666 rickwu666666 self-requested a review January 15, 2025 03:35
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried the change on two different projects that have RS485. And works fine.

@hanhsuan hanhsuan marked this pull request as ready for review January 15, 2025 04:46
@hanhsuan hanhsuan merged commit b3b62f3 into canonical:main Jan 17, 2025
13 of 14 checks passed
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (b1dfd6f) to head (d3842b7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   48.99%   48.99%           
=======================================
  Files         372      372           
  Lines       40321    40321           
  Branches     6811     6811           
=======================================
  Hits        19757    19757           
  Misses      19842    19842           
  Partials      722      722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ce-oem The PR only contains to the ce-oem provider under the contrib area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants