-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[checkbox-ce-oem] Enhance serial test to be more stable (Bugfix) #1682
Conversation
2. clean up garbage in the serial port before testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
@rickwu666666 mention the client mode couldn't work on his side, let's check it before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried the change on two different projects that have RS485. And works fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 372 372
Lines 40321 40321
Branches 6811 6811
=======================================
Hits 19757 19757
Misses 19842 19842
Partials 722 722 ☔ View full report in Codecov by Sentry. |
Description
Resolved issues
Documentation
Tests
https://certification.canonical.com/hardware/202405-34046/submission/408239/