-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contrib provider ce-oem GitHub workflow (Infra) #938
Conversation
a58d8a1
to
30ead3a
Compare
This workflow comes from the original Git repository and is no longer needed.
This workflow is adapted from existing workflows used for the generic providers.
- Point to the correct version of Python using {envpython} - Remove the "develop installation" step for the ce-oem provider - Convert the test step into a test coverage one to generate an XML report to be used later by Codecov
Following Codecov documentation on flags[1], use the `contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark Codecov status checks as non-blocking[3]. [1] https://docs.codecov.com/docs/flags [2] .github/workflows/tox-contrib-provider-ce-oem.yaml [3] https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks
ade379a
to
3638a5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 38.98% 37.87% -1.12%
==========================================
Files 315 333 +18
Lines 34893 36913 +2020
Branches 5971 6301 +330
==========================================
+ Hits 13604 13981 +377
- Misses 20678 22312 +1634
- Partials 611 620 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, ty
* Remove old ce-oem workflow This workflow comes from the original Git repository and is no longer needed. * Add workflow for the ce-oem provider This workflow is adapted from existing workflows used for the generic providers. * Update contrib ce-oem tox config - Point to the correct version of Python using {envpython} - Remove the "develop installation" step for the ce-oem provider - Convert the test step into a test coverage one to generate an XML report to be used later by Codecov * Point to the right directory for generic providers * Install ce-oem provider prior to run validation on it * Add codecov config for ce-oem contrib provider Following Codecov documentation on flags[1], use the `contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark Codecov status checks as non-blocking[3]. [1] https://docs.codecov.com/docs/flags [2] .github/workflows/tox-contrib-provider-ce-oem.yaml [3] https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks * Fix tox configuration for ce-oem provider * Add coverage requirement to ce-oem tox config * Add coverage config to ce-oem provider * Update codecov config to make project status non-blocking for ce-oem provider * Change job id and add a name to it for easier reference
* Remove old ce-oem workflow This workflow comes from the original Git repository and is no longer needed. * Add workflow for the ce-oem provider This workflow is adapted from existing workflows used for the generic providers. * Update contrib ce-oem tox config - Point to the correct version of Python using {envpython} - Remove the "develop installation" step for the ce-oem provider - Convert the test step into a test coverage one to generate an XML report to be used later by Codecov * Point to the right directory for generic providers * Install ce-oem provider prior to run validation on it * Add codecov config for ce-oem contrib provider Following Codecov documentation on flags[1], use the `contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark Codecov status checks as non-blocking[3]. [1] https://docs.codecov.com/docs/flags [2] .github/workflows/tox-contrib-provider-ce-oem.yaml [3] https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks * Fix tox configuration for ce-oem provider * Add coverage requirement to ce-oem tox config * Add coverage config to ce-oem provider * Update codecov config to make project status non-blocking for ce-oem provider * Change job id and add a name to it for easier reference
Description
Resolved issues
CHECKBOX-1157
Documentation
Tests
Used Codecov validation to check the codecov.yml file was valid: