Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contrib provider ce-oem GitHub workflow (Infra) #938

Merged
merged 11 commits into from
Jan 24, 2024

Conversation

pieqq
Copy link
Collaborator

@pieqq pieqq commented Jan 16, 2024

Description

  1. Add workflow for the ce-oem provider (this workflow is adapted from existing workflows used for the generic providers)
  2. Update contrib ce-oem tox config:
    • Point to the correct version of Python using {envpython}
    • Remove the "develop installation" step for the ce-oem provider
    • Convert the test step into a test coverage one to generate an XMLreport to be used later by Codecov
  3. Update codecov configuration for the ce-oem provider in the contrib area (to make the check non-blocking both as a patch and for the whole project)

Resolved issues

CHECKBOX-1157

Documentation

Tests

Used Codecov validation to check the codecov.yml file was valid:

curl -X POST --data-binary @codecov.yml https://codecov.io/validate

@pieqq pieqq changed the title Add contrib provider ce oem workflow (Infra) Add contrib provider ce-oem workflow (Infra) Jan 16, 2024
@pieqq pieqq changed the title Add contrib provider ce-oem workflow (Infra) Add contrib provider ce-oem GitHub workflow (Infra) Jan 16, 2024
@pieqq pieqq force-pushed the add-contrib-provider-ce-oem-workflow branch 2 times, most recently from a58d8a1 to 30ead3a Compare January 16, 2024 08:47
pieqq added 7 commits January 17, 2024 09:41
This workflow comes from the original Git repository and is no longer
needed.
This workflow is adapted from existing workflows used for the generic
providers.
- Point to the correct version of Python using {envpython}
- Remove the "develop installation" step for the ce-oem provider
- Convert the test step into a test coverage one to generate an XML
report to be used later by Codecov
Following Codecov documentation on flags[1], use the
`contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark
Codecov status checks as non-blocking[3].

[1] https://docs.codecov.com/docs/flags
[2] .github/workflows/tox-contrib-provider-ce-oem.yaml
[3]
https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks
@pieqq pieqq force-pushed the add-contrib-provider-ce-oem-workflow branch from ade379a to 3638a5b Compare January 17, 2024 01:42
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (228b716) 38.98% compared to head (a8b873d) 37.87%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   38.98%   37.87%   -1.12%     
==========================================
  Files         315      333      +18     
  Lines       34893    36913    +2020     
  Branches     5971     6301     +330     
==========================================
+ Hits        13604    13981     +377     
- Misses      20678    22312    +1634     
- Partials      611      620       +9     
Flag Coverage Δ
contrib-provider-ce-oem 18.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, ty

@Hook25 Hook25 merged commit 727e004 into main Jan 24, 2024
12 of 13 checks passed
@Hook25 Hook25 deleted the add-contrib-provider-ce-oem-workflow branch January 24, 2024 08:34
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
* Remove old ce-oem workflow

This workflow comes from the original Git repository and is no longer
needed.

* Add workflow for the ce-oem provider

This workflow is adapted from existing workflows used for the generic
providers.

* Update contrib ce-oem tox config

- Point to the correct version of Python using {envpython}
- Remove the "develop installation" step for the ce-oem provider
- Convert the test step into a test coverage one to generate an XML
report to be used later by Codecov

* Point to the right directory for generic providers

* Install ce-oem provider prior to run validation on it

* Add codecov config for ce-oem contrib provider

Following Codecov documentation on flags[1], use the
`contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark
Codecov status checks as non-blocking[3].

[1] https://docs.codecov.com/docs/flags
[2] .github/workflows/tox-contrib-provider-ce-oem.yaml
[3]
https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks

* Fix tox configuration for ce-oem provider

* Add coverage requirement to ce-oem tox config

* Add coverage config to ce-oem provider

* Update codecov config to make project status non-blocking for ce-oem provider

* Change job id and add a name to it for easier reference
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
* Remove old ce-oem workflow

This workflow comes from the original Git repository and is no longer
needed.

* Add workflow for the ce-oem provider

This workflow is adapted from existing workflows used for the generic
providers.

* Update contrib ce-oem tox config

- Point to the correct version of Python using {envpython}
- Remove the "develop installation" step for the ce-oem provider
- Convert the test step into a test coverage one to generate an XML
report to be used later by Codecov

* Point to the right directory for generic providers

* Install ce-oem provider prior to run validation on it

* Add codecov config for ce-oem contrib provider

Following Codecov documentation on flags[1], use the
`contrib-provider-ce-oem` flag defined in the GitHub workflow[2] to mark
Codecov status checks as non-blocking[3].

[1] https://docs.codecov.com/docs/flags
[2] .github/workflows/tox-contrib-provider-ce-oem.yaml
[3]
https://docs.codecov.com/docs/common-recipe-list#set-non-blocking-status-checks

* Fix tox configuration for ce-oem provider

* Add coverage requirement to ce-oem tox config

* Add coverage config to ce-oem provider

* Update codecov config to make project status non-blocking for ce-oem provider

* Change job id and add a name to it for easier reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants