Adding metabox tests to packaging (Infra) #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando79513
force-pushed
the
adding-metabox-tests-to-packaging
branch
from
c3d52ef to
bb03eae
Compare
fernando79513
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 39.19% 39.19%
=======================================
Files 315 315
Lines 34898 34898
Branches 5972 5972
=======================================
Hits 13679 13679
Misses 20608 20608
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This test makes sure that the current packaging driver is applicable for a specific os version.
fernando79513
force-pushed
the
adding-metabox-tests-to-packaging
branch
from
bb03eae to
4f63223
Compare
Hook25
requested changes
Jan 22, 2024
Co-authored-by: Massimiliano <[email protected]>
Hook25
approved these changes
Jan 23, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Added new metabox test for packaging versions This test makes sure that the current packaging driver is applicable for a specific os version. * Added assert in file * Fixed run_manage and assert_in_file actions * Cleaned previous implementation of the tests * Apply suggestions from code review Co-authored-by: Massimiliano <[email protected]> * Applied the rest of the PR comments * Added a Xenial scenario --------- Co-authored-by: Massimiliano <[email protected]>
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Added new metabox test for packaging versions This test makes sure that the current packaging driver is applicable for a specific os version. * Added assert in file * Fixed run_manage and assert_in_file actions * Cleaned previous implementation of the tests * Apply suggestions from code review Co-authored-by: Massimiliano <[email protected]> * Applied the rest of the PR comments * Added a Xenial scenario --------- Co-authored-by: Massimiliano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a followup to #909, We have implemented a new metabox tests that checks that a "packaging.pxu" file produces the correct output "substvar" file with the propper dependencies.
This new test takes a more E2E approach as suggested. Now, we run the test directly from the scenario without having to all any external python script. For that purpose, we have added two new more actions:
Resolved issues
Closes https://warthogs.atlassian.net/browse/CHECKBOX-1156
Documentation
No changes to the documentation
Tests
To run the tests:
metabox configs/local-source-18.04.py --tag packaging: the test should not pass in bionicmetabox configs/local-source-20.04.py --tag packaging: the test should pass in focalmetabox configs/local-source-22.04.py --tag packaging: the test should pass in jammy