Removed unused screenshot tests (BugFix) #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`camera_test.py` was called with a device that does not exist and outputs a non-informative error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
=======================================
Coverage 38.98% 38.98%
=======================================
Files 333 333
Lines 37045 37045
Branches 6316 6316
=======================================
Hits 14441 14441
Misses 21976 21976
Partials 628 628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kissiel
approved these changes
Feb 19, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
Removed unused screenshot tests `camera_test.py` was called with a device that does not exist and outputs a non-informative error.
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
Removed unused screenshot tests `camera_test.py` was called with a device that does not exist and outputs a non-informative error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
camera_test.pywas called with a device that does not exist and outputs a non-informative error. We are removing these tests since they are not relevant anymore.Resolved issues
Closes #339
Closes jira CHECKBOX-1232
Documentation
There are no changes to the documentation
Tests
Running
checkbox-cli list "all-jobs" | grep screenshotshows that there are not any screenshot tests