Adds the envoy rock #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Jul 30, 2024
bschimke95
reviewed
Jul 30, 2024
Trims whitespaces. Adds quiet option to wget, which polluted the output logs. Replaced bazel.sizeopt.server_only with sizeopt.server_only, the bazel. prefix is deprecated. Removes ENVOY_DOCKER_BUILD_DIR, that only applies for docker-based image building.
There are some issues when trying to use the github runners for building the envoy rock, specifically when it comes to building and linking the envoy binary. The Runner can lose communication with the server due to CPU / Memory starvation, causing the runner to be terminated. The self-hosted runners are bigger, so the compilation time should be significantly smaller, and it shouldn't end up in resource starvation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the original PR: #1
Adds the envoy rock.
Switches amd64 runner with a self-hosted one. There are some issues when trying to use the github runners for building the envoy rock, specifically when it comes to building and linking the envoy binary. The Runner can lose communication with the server due to CPU / Memory starvation, causing the runner to be terminated.
The self-hosted runners are bigger, so the compilation time should be significantly smaller, and it shouldn't end up in resource starvation.