Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing commands to ref #976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: add missing commands to ref #976

wants to merge 2 commits into from
+9 −1

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Jan 16, 2025 •
edited
Loading

  • Adds missing k8s commands to the command reference page:
    • k8s refresh-certs
    • k8s completion
  • Remove redundant "reference" word from page title/nav

@eaudetcobello eaudetcobello requested a review from a team as a code owner January 16, 2025 23:08
@bschimke95
Copy link
Contributor

Huh, I thought this reference is autogenerated?
Or are just the commands generated and the they still need to be linked manually (ugh...)

@eaudetcobello
Copy link
Contributor Author

Huh, I thought this reference is autogenerated? Or are just the commands generated and the they still need to be linked manually (ugh...)

Right, they need to be linked manually

nhennigan
nhennigan approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can look at trying to complete the automation in the future but LGTM for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhennigan nhennigan nhennigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eaudetcobello @bschimke95 @nhennigan