-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: publish the graphics enablement doc on rtd #3334
doc: publish the graphics enablement doc on rtd #3334
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3334 +/- ##
==========================================
- Coverage 77.36% 77.35% -0.01%
==========================================
Files 1075 1075
Lines 68268 68268
==========================================
- Hits 52813 52812 -1
- Misses 15455 15456 +1 ☔ View full report in Codecov by Sentry. |
1a51ad5
to
4765102
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline
@RAOF Can you expand a bit more on the following comments, not sure how to address: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, whoops! I totally missed that we didn't really update for any of the graphics-core22 changes on my first pass through!
That makes it both easier and harder. This is our only documentation on creating a provider snap, and it's a little bare, but perhaps what should be done here is to link out to that and improve it?
Then remove (or, really, move into a better provider creating document) everything from
## How to assemble a `graphics-core22` provider snap
until
## How to test a `graphics-core22` provider snap
Why would we link out to that though? Shouldn't this document be the document on creating a provider snap, while the other one gets merged into this? |
If you need help doing or testing a |
7914f1f
to
bf3f18f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor changes, but I think we've got the big stuff!
98fb63f
to
88f920f
Compare
88f920f
to
06e3b30
Compare
@RAOF Committed the requested changes and cleaned up the history 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What's new?
graphics-core22
. @RAOF please let me know if any of my assumptions aboutgraphics-core22
were incorrect here, since the original document was intended forgraphics-core20
How to test?