Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: increase the test timeout #3704

Merged
merged 1 commit into from
Dec 19, 2024
Merged

smoke: increase the test timeout #3704

merged 1 commit into from
Dec 19, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Dec 19, 2024

Slower devices (RPi3) did not keep up reliably.

Slower devices (RPi3) did not keep up reliably.
@Saviq
Copy link
Collaborator Author

Saviq commented Dec 19, 2024

I can reproduce this within a dozen runs:

[2024-12-18 20:37:57.766490] < -warning- > server_example_test_client.cpp: Client has not exited: Terminating client
[2024-12-18 20:37:57.766987] <information> mirserver: Stopping
I: [FAILED] /snap/mir-test-tools/16552/usr/bin/mir_demo_client_wayland

And with the increased timeout, have not seen it yet.

@Saviq Saviq marked this pull request as ready for review December 19, 2024 13:22
@Saviq Saviq requested a review from a team as a code owner December 19, 2024 13:22
@Saviq
Copy link
Collaborator Author

Saviq commented Dec 19, 2024

OTOH looking at a successful run:

[2024-12-19 13:00:35.271364] <information> mir::examples: Starting test client: /snap/mir-test-tools/17540/usr/bin/mir_demo_client_wayland
# ...
[2024-12-19 13:00:38.371156] <information> server_example_test_client.cpp: Client exited successfully

vs. a failed one:

[2024-12-19 13:00:53.416569] <information> mir::examples: Starting test client: /snap/mir-test-tools/17540/usr/bin/mir_demo_client_wayland
# ...
[2024-12-19 13:01:06.421952] < -warning- > server_example_test_client.cpp: Client has not exited: Terminating client

That's 3s vs. 13s…

Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 617948e Dec 19, 2024
68 of 75 checks passed
@AlanGriffiths AlanGriffiths deleted the longer-smoke-timeout branch December 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants