Release v2.19.3

CMakeLists.txt

@@ -26,7 +26,7 @@ set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
 set(MIR_VERSION_MAJOR 2)
 set(MIR_VERSION_MINOR 19)
-set(MIR_VERSION_PATCH 2)
+set(MIR_VERSION_PATCH 3)
 
 add_compile_definitions(MIR_VERSION_MAJOR=${MIR_VERSION_MAJOR})
 add_compile_definitions(MIR_VERSION_MINOR=${MIR_VERSION_MINOR})

debian/changelog

@@ -1,3 +1,13 @@
+mir (2.19.3) UNRELEASED; urgency=medium
+
+  * New upstream release 2.19.3
+
+    - Bug fixes:
+      . Don't leak VirtualInputDevice keyboards (#3720)
+      . kms: skip `simple-framebuffer` devices (#3721)
+
+ -- Michał Sawicz <[email protected]>  Thu, 16 Jan 2025 15:07:09 +0100
+
 mir (2.19.2) UNRELEASED; urgency=medium
 
   * New upstream release 2.19.2

src/platforms/atomic-kms/server/kms/quirks.cpp

@@ -158,8 +158,12 @@ class mga::Quirks::Impl
      *
      * At least as of drivers ≤ version 550, the NVIDIA atomic implementation is buggy in a way that prevents
      * Mir from working. Quirk off atomic-kms on NVIDIA.
+     *
+     * Simple-framebuffer should be evicted before Mir even gets there.
+     * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2084046
+     * https://github.com/canonical/mir/issues/3710
      */
-    std::unordered_set<std::string> drivers_to_skip = { "nvidia", "ast" };
+    std::unordered_set<std::string> drivers_to_skip = { "nvidia", "ast", "simple-framebuffer"};
     std::unordered_set<std::string> devnodes_to_skip;
     // We know this is currently useful for virtio_gpu, vc4-drm and v3d
     std::unordered_set<std::string> skip_modesetting_support = { "virtio_gpu", "vc4-drm", "v3d" };

src/platforms/gbm-kms/server/kms/quirks.cpp

@@ -158,8 +158,12 @@ class mgg::Quirks::Impl
      *
      * At least as of drivers ≤ version 550, the NVIDIA gbm implementation is buggy in a way that prevents
      * Mir from working. Quirk off gbm-kms on NVIDIA.
+     *
+     * Simple-framebuffer should be evicted before Mir even gets there.
+     * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2084046
+     * https://github.com/canonical/mir/issues/3710
      */
-    std::unordered_set<std::string> drivers_to_skip = { "nvidia", "ast" };
+    std::unordered_set<std::string> drivers_to_skip = { "nvidia", "ast", "simple-framebuffer"};
     std::unordered_set<std::string> devnodes_to_skip;
     // We know this is currently useful for virtio_gpu, vc4-drm and v3d
     std::unordered_set<std::string> skip_modesetting_support = { "virtio_gpu", "vc4-drm", "v3d" };

src/server/frontend_wayland/text_input_v3.cpp

@@ -333,6 +333,7 @@ mf::TextInputV3::TextInputV3(
 mf::TextInputV3::~TextInputV3()
 {
     seat.remove_focus_listener(client, this);
+    ctx->device_registry->remove_device(keyboard_device);
     ctx->text_input_hub->deactivate_handler(handler);
 }