Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard istio ztunnel #342

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IbraAoad
Copy link
Contributor

@IbraAoad IbraAoad commented Feb 4, 2025

Ping the @canonical/rocks team.


Description

This PR adds the ztunnel ROCK to the OCI factory.

Related issues

#317

@IbraAoad IbraAoad requested a review from a team as a code owner February 4, 2025 12:27
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code.

I have to manually terminate the workflow runs for the black-box testing, as this rock is causing infinite loops there.

The is due to using ztunnel as the entrypoint-service rather than the default pebble, causing the test to fail to run the command pebble help, while having pebble indefinitely trying to run the failing ztunnel [ ] command.

Besides, using the programs other than pebble as the entry point service does not comply with the guidelines to build rocks. You can observe the warnings when running rockcraft pack:

Warning: defining an entrypoint-service will result in a rock with an atypical OCI Entrypoint. While that might be acceptable for testing and personal use, it shall require prior approval before submitting to a Canonical registry namespace.

I believe it is necessary to change the entry point service of this rock. Otherwise, please provide justifications for doing so.

Discussions are welcomed. Cheers!

@simskij
Copy link
Member

simskij commented Feb 5, 2025

@zhijie-yang

I believe it is necessary to change the entry point service of this rock. Otherwise, please provide justifications for doing so.

Discussions are welcomed. Cheers!

We cannot get rid of the entrypoint service, as Istio launches the container with arguments that are resolved at deploy-time. As the rock needs to be interchangeable with the upstream OCI, we can't really change this without making the rock unusable outside of the charm context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants