Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otel [very draftey draft] #1527

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Jan 15, 2025

[tbd]

Files

ops/jujuversion.py -- lightweight, no need to instrument
ops/tracing/_buffer.py -- new
ops/tracing/__init__.py -- new, shim only
ops/tracing/_hacks.py -- may have to run first, would have to be exempt
ops/tracing/_fixme.py -- the guts, like sending telemetry out... exempt or not?
ops/version.py -- static content, nothing to instrument
ops/_main.py -- started, possibly more to do
ops/log.py -- recursion prevention added
ops/charm.py -- started
ops/pebble.py -- TBD started, mostly relying on urllib instrumentation though
ops/framework.py -- TBD started
ops/__init__.py -- only shims, no need to instrument
ops/_private/harness.py -- test only
ops/_private/__init__.py -- empty
ops/_private/yaml.py -- done
ops/_private/timeconv.py
ops/model.py
ops/storage.py
ops/lib/__init__.py -- deprecated, will not touch
ops/jujucontext.py -- lightweight, no need to instrument
ops/main.py -- shim only, no need to instrument
ops/testing.py -- out of scope

Functionality

@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 15, 2025

Notes:

  • adds opentelemetry-api (64kB wheel) to dependencies
  • adds a bunch of opentelemetry-this-and-that (total size tbd) to ops[tracing] dependency group

@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 17, 2025

No idea why RTD build fails...

HACKING.md Outdated
@@ -471,7 +471,7 @@ The main improvements in this release are ...
Read more in the [full release notes on GitHub](link to the GitHub release).
```

In the post, outline the key improvements both in `ops` and `ops-scenario` -
In the post, outline the key improvements both in `ops` and `ops-scenario` -
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a bug in main, not a part of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwilding wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess something (tooling/automation?) removed the trailing space. I need to do a separate PR for HACKING.md to fix something else, so I'll change this. Thanks for pointing it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to change this: #1539

@dimaqq dimaqq force-pushed the feat-otel branch 2 times, most recently from 44fde41 to a483e07 Compare January 27, 2025 00:57
@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 27, 2025

squashed and rebased: #1539 got merged; #1538 a no-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants