Drop wait argument from image create

[hamistao]

This removes a useless parameter that was supposed to be removed on 2.3 release.

[tomponline]

@hamistao @simondeziel is this an API break?

[hamistao]

@tomponline yes, it is. But it should have landed a few releases ago and since then this argument is ignored.

[tomponline]

@tomponline yes, it is. But it should have landed a few releases ago and since then this argument is ignored.

Hrm, yeah, but we recently had a separate issue with changes that broke the pylxd API, was there consideration given about users who are providing this optional value?

[hamistao]

I believe @simondeziel hasn't seen this yet, so we can discuss further after he does. I think it should be safe to remove it since this parameter is being ignored for the past 8 years.

[simondeziel]

The deprecation warning was added in 2016-11 but as you pointed out @tomponline this is a breaking change. There are quite a few users of that: https://github.com/search?q=pylxd+images.create%28+language%3APython&type=code

How about you drop the first commit (c3d7c00) from your PR? This way, our doc and tests will stop providing this param that defaults to True anyway.

[hamistao]

@simondeziel Thanks for doing this research, I underestimate how useful GitHub's search can be. This is ready for another review.