Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-6116 Add backup and restore integration test to Ranger charm #22

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

AmberCharitos
Copy link
Contributor

@AmberCharitos AmberCharitos commented Jan 29, 2024

This PR:

  • Updates README with information regarding setting up postgresql backupand restore functionality
  • Creates an integration test to validate the Ranger application is stateless
  • Makes the repeatable get_memberships a helper function
  • Updates libs

Please note: this will fail the license header test untll this PR is merged: #21

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 35 files.

Valid Invalid Ignored Fixed
0 18 17 0
Click to see the invalid file list
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • metadata.yaml
  • pyproject.toml
  • src/charm.py
  • src/groups.py
  • src/literals.py
  • src/relations/postgres.py
  • src/relations/provider.py
  • src/state.py
  • src/utils.py
  • tests/integration/conftest.py
  • tests/integration/helpers.py
  • tests/integration/test_charm.py
  • tests/unit/init.py
  • tests/unit/test_charm.py
  • tox.ini

Copy link
Collaborator

@kelkawi-a kelkawi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

tests/integration/helpers.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/test_charm.py Outdated Show resolved Hide resolved
tests/integration/helpers.py Show resolved Hide resolved
@AmberCharitos AmberCharitos merged commit a0df583 into main Jan 30, 2024
12 checks passed
@gtato gtato deleted the CSS-6116-dog2-backup-and-restore branch September 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants