Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-7347 Ranger usersync #25

Merged
merged 15 commits into from
Mar 8, 2024
Merged

CSS-7347 Ranger usersync #25

merged 15 commits into from
Mar 8, 2024

Conversation

AmberCharitos
Copy link
Contributor

@AmberCharitos AmberCharitos commented Mar 2, 2024

Adds the Ranger usersync charm function:

  • Additional configuration values
  • Ranger usersync install.properties
  • Ranger usersync integration test with OpenLDAP charm

Additionally adds:

  • Structured config to manage config validation
  • LDAP optional relation handler. If the openldap charm is related it takes these values provided if not then it uses config.

Refactors:

  • Integration tests to decouple the Trino integration testing from the other tests.

Removes:

  • Old method of synchronisation through Unix users and configuration file

@AmberCharitos AmberCharitos changed the title Ranger usersync CSS-7347 Ranger usersync Mar 4, 2024
src/charm.py Outdated Show resolved Hide resolved
src/structured_config.py Show resolved Hide resolved
Copy link
Collaborator

@mertalpt mertalpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, previous comments are minor enough that I can just approve.

Copy link
Collaborator

@kelkawi-a kelkawi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
src/relations/ldap.py Outdated Show resolved Hide resolved
src/relations/ldap.py Show resolved Hide resolved
src/relations/ldap.py Show resolved Hide resolved
tests/integration/test_usersync.py Outdated Show resolved Hide resolved
@AmberCharitos AmberCharitos merged commit 4b42999 into main Mar 8, 2024
15 checks passed
@gtato gtato deleted the ranger-usersync branch September 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants