Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cos-lite relations + update libs #26

Merged
merged 1 commit into from
Apr 25, 2024
Merged

add cos-lite relations + update libs #26

merged 1 commit into from
Apr 25, 2024

Conversation

AmberCharitos
Copy link
Contributor

This PR adds integrated observability to the Ranger charm in line with DOG2 requirements. It adds:

  • Loki, prometheus and grafana libraries & requirer/provider interfaces
  • Grafana dashboard template for monitoring Ranger metrics.
  • Literals for the metrics port and log files

Screenshot from 2024-04-22 15-15-38
Screenshot from 2024-04-22 14-30-54

Please note this PR for the ROCK must be merged first: canonical/charmed-ranger-rock#3

mertalpt
mertalpt approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@mertalpt mertalpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to go the extra mile, you can set the units on dashboard panels so that millions of bytes show up as MBs for example.

onurmus
onurmus approved these changes Apr 25, 2024
View reviewed changes
Copy link

@onurmus onurmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kelkawi-a
kelkawi-a approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@kelkawi-a kelkawi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmberCharitos AmberCharitos merged commit 6a938dd into main Apr 25, 2024
15 checks passed
@gtato gtato deleted the CSS-6113-dog2-observability branch September 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelkawi-a kelkawi-a kelkawi-a approved these changes

@mertalpt mertalpt mertalpt approved these changes

@onurmus onurmus onurmus approved these changes

@gtato gtato Awaiting requested review from gtato

@maabujayyab maabujayyab Awaiting requested review from maabujayyab

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmberCharitos @onurmus @mertalpt @kelkawi-a