Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-9793 Make ranger usersync password configurable #31

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

AmberCharitos
Copy link
Contributor

The usersync password was previously hard coded in ranger usersync and set to be the same as the admin password in ranger admin. This was causing mismatches when the admin password was updated. This PR resolves this by providing a config value for setting this password in both admin and usersync.

Note: ideally this password would be set in ranger admin and passed through a relation to Ranger usersync. However, there are a couple of configuration values that should be passed via a relation so I have created a follow up story to do this for this field as well as the others: https://warthogs.atlassian.net/browse/CSS-9803.

@AmberCharitos AmberCharitos changed the title Make ranger usersync password configurable CSS-9793 Make ranger usersync password configurable Jul 23, 2024
src/structured_config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kelkawi-a kelkawi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment that can potentially improve the charm's experience when the user changes the password after initial set up.

config.yaml Show resolved Hide resolved
@AmberCharitos AmberCharitos merged commit 1ba4200 into main Jul 23, 2024
15 checks passed
@gtato gtato deleted the usersync-password branch September 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants