snap: add skopeo as an app #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
changed the title
tigarmo
reviewed
Nov 2, 2023
| @@ -18,6 +18,8 @@ environment: | |||
| apps: | |||
| rockcraft: | |||
| command: bin/python $SNAP/bin/rockcraft | |||
| skopeo: | |||
There was a problem hiding this comment.
I think this is a very good idea! My only possible concern is whether we then need to maintain this as part of the "public api" forever and ever
@sergiusens what do you think?
Allows running the rockcraft-packaged copy of skopeo as `rockcraft.skopeo`
|
Sounds like we're not going to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running the rockcraft-packaged copy of skopeo as
rockcraft.skopeo