Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: replace yamllint with prettier #794

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Jan 24, 2025

This PR has a series of commits. The first one is a "manual cherry-pick" of starbase/805, and this one is the automated result of running make format-prettier (no manual changes).

Spread failure is unrelated!

Fixes #791

  • Have you signed the CLA?

This commit is a manual application of bits of starbase/305.
Add a prettierignore file for those files we want to skip, and fix
the globbing passed to the tool - we want prettier to parse those,
not bash.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 24, 2025
common.mk Show resolved Hide resolved
@tigarmo tigarmo added the rebase label Jan 24, 2025
@tigarmo tigarmo marked this pull request as ready for review January 24, 2025 18:32
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you know to fix the templates?

@tigarmo
Copy link
Collaborator Author

tigarmo commented Jan 24, 2025

How did you know to fix the templates?

We have tests that check the default output. The tests have expected files which are yamls, which got fixed by prettier
the system works!

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just an excuse to have a net-negative PR?

Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/renovate.json5 Show resolved Hide resolved
rockcraft/pebble.py Show resolved Hide resolved
@tigarmo tigarmo merged commit c8c5883 into main Jan 24, 2025
18 of 20 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3977-prettier branch January 24, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint yaml files with prettier
4 participants