-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: replace yamllint with prettier #794
Conversation
This commit is a manual application of bits of starbase/305.
Add a prettierignore file for those files we want to skip, and fix the globbing passed to the tool - we want prettier to parse those, not bash.
No manual changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you know to fix the templates?
We have tests that check the default output. The tests have expected files which are yamls, which got fixed by prettier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this just an excuse to have a net-negative PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR has a series of commits. The first one is a "manual cherry-pick" of starbase/805, and this one is the automated result of running
make format-prettier
(no manual changes).Spread failure is unrelated!
Fixes #791