Update craft parts, minor build and ci fixes #799
Merged
+381
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tigarmo
commented
Jan 30, 2025
tigarmo
commented
- Have you signed the CLA?
github-actions
bot
added
the
documentation
tigarmo
commented
Jan 30, 2025
| runs-on: [self-hosted] | ||
| steps: | ||
| - name: Create a Prerelease | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
I'm not actually sure if this action can work without the code checked-out
we'll see
tigarmo
commented
Jan 30, 2025
| @@ -591,7 +591,7 @@ wheels = [ | |||
|
|
|||
| [[package]] | |||
| name = "craft-parts" | |||
| version = "2.4.1" | |||
| version = "2.5.0" | |||
There was a problem hiding this comment.
done with uv lock --upgrade-package craft-parts
I've always been a big uv fan, it is known
tigarmo
force-pushed
the
work/craft-parts-2.5.0
branch
8 times, most recently
from
2955721 to
363bbfe
Compare
bepri
approved these changes
Jan 30, 2025
This new version brings in the jlink plugin, so we update the docs and schema.
The package shouldn't be needed in cases. The exception is environments where there's no wheel available for the version of pygit2 that we need, such as the recent release of Python 3.13.1.
This app-specific workflow does not build the wheel or publish it - it just creates the Github release, as a prerelease.
Since we use this as a context manager we need to go "deeper" to set the return value on the correct attribute. The previous version fails on Python 3.13 as Path objects can no longer be used as context managers.
These versions of Python are missing wheels for either python-apt or pygit2. We can re-enable these versions once the wheels are up.
tigarmo
force-pushed
the
work/craft-parts-2.5.0
branch
from
92ea3df to
6b3cfa2
Compare
This brings in the .readthedocs.yaml file from starbase
tigarmo
force-pushed
the
work/craft-parts-2.5.0
branch
from
6b3cfa2 to
6b6ca2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.