efi: fix a couple of review comments

canonical · Jun 11, 2024 · ecc15ab · ecc15ab
1 parent 996a488
commit ecc15ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/efi/image_rules_defs.go b/efi/image_rules_defs.go
@@ -50,7 +50,7 @@ func makeMicrosoftUEFICASecureBootNamespaceRules() *secureBootNamespaceRules {
 				0x13, 0xad, 0xbf, 0x43, 0x09, 0xbd, 0x82, 0x70, 0x9c, 0x8c,
 				0xd5, 0x4f, 0x31, 0x6e, 0xd5, 0x22, 0x98, 0x8a, 0x1b, 0xd4,
 			},
-			// pubkey a;g
+			// pubkey alg
 			x509.RSA,
 		),
 		// TODO(chrisccoulson): add tests for this when we find something that it's

diff --git a/efi/pcr_profile.go b/efi/pcr_profile.go
@@ -28,17 +28,17 @@ import (
 	"golang.org/x/xerrors"
 )
 
+// PCRProfileOption is an option for AddPCRProfile
+type PCRProfileOption interface {
+	applyOptionTo(gen *pcrProfileGenerator)
+}
+
 // PCRProfileEnablePCRsOption is an option for AddPCRProfile that adds one or more PCRs.
 type PCRProfileEnablePCRsOption interface {
 	PCRProfileOption
 	PCRs() tpm2.HandleList
 }
 
-// PCRProfileOption is an option for AddPCRProfile
-type PCRProfileOption interface {
-	applyOptionTo(gen *pcrProfileGenerator)
-}
-
 type pcrProfileSetPcrsOption struct {
 	PCRProfileOption
 	pcrs pcrFlags