efi: remove deprecated APIs #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
efi-remove-deprecated-apis
branch
from
967dcf0 to
fadf272
Compare
|
Ugh, of course, this also makes tools/gen-compatdata unusable, so I'll need to fix that first |
pedronis
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
lgtm
Ugh, of course, this also makes tools/gen-compatdata unusable, so I'll need to fix that first
if the data is checked in as we discussed and the tests pass and do not want to block on this, you can leave a TODO there and come back in a different PR
You can also comment out code at the same time to help landing things
This tool hasn't worked since canonical#156. As canonical#274 also makes it unbuildable, comment out the unbuildable code for now and return an error.
chrisccoulson
added a commit
to chrisccoulson/secboot
that referenced
this pull request
Nov 28, 2023
canonical#274 deleted a test key that was used by the mock dual signed shim. Rather than resurrecting the entire certificate chain, this brings back one deleted leak key and then uses this to create one of the signatures on the mock dual signed binary.
chrisccoulson
added a commit
that referenced
this pull request
Nov 28, 2023
…-key efi: resurrect a deleted test key. #274 deleted a test key that was used by the mock dual signed shim. Rather than resurrecting the entire certificate chain, this brings back one deleted leaf key and then uses this to create one of the signatures on the mock dual signed binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes deprecated APIs and test data, and will make it easier to
generate new mock binaries without having to adjust digests in associated
unit tests. I want to generate new mock grub binaries in another PR to add
the EFI prefix.
Note that this removes some data that is used by tools/gen-compattest-data,
but it turns out that a previous PR (#156)
already removed test data required by it and it hasn't worked since then. I need
to rework how we test that changes are backwards compatible, so I'll fix that in
another PR.