luks2: don't time tests to verify KDF settings #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
luks2-dont-time-tests
branch
from
96a8f58 to
651f6dd
Compare
chrisccoulson
force-pushed
the
luks2-dont-time-tests
branch
from
651f6dd to
ab491aa
Compare
There are a few tests where we time the KDF operation because there isn't another way to determine if it was configured correctly by cryptsetup. These tests have always been a little bit flaky, and they have been significantly more so recently. Stop timing them, and instead: - in internal/luks2, just rely on the fact that we verify the expected commandline arguments were passed to cryptsetup. We have to assume that these options are correct, which is what the existing tests attempted to confirm. - in crypt_test.go, ensure that we pass the correct target time to internal/luks2.
chrisccoulson
force-pushed
the
luks2-dont-time-tests
branch
from
ab491aa to
8a936b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few tests where we time the KDF operation because there
isn't another way to determine if it was configured correctly by
cryptsetup. These tests have always been a little bit flaky, and they
have been significantly more so recently.
Stop timing them, and instead:
commandline arguments were passed to cryptsetup. We have to assume
that these options are correct, which is what the existing tests
attempted to confirm.
internal/luks2.