Add plainkey platform #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
add-plainkey-platform
branch
5 times, most recently
from
cd5594c to
166eab8
Compare
chrisccoulson
force-pushed
the
add-plainkey-platform
branch
3 times, most recently
from
57c878b to
5d9b63e
Compare
chrisccoulson
force-pushed
the
add-plainkey-platform
branch
from
5d9b63e to
72c15d7
Compare
This platform provides a way to unlock an encrypted container using a key recovered from unlocking another container, and is suitable when access to one encrypted container implies access to another one. The intention of this is to replace the existing mechanism for unlocking the save partition in run mode with something that uses a proper keyslot. Keys are protected with a "platform key" - this is the key that is stored in the first encrypted container. For the intended use case, this key is stored inside the data partition, and then loaded by snap-bootstrap, which should call plainkey.SetPlatformKeys before unlocking the save partition. Although normally there will only be a single key supplied to SetPlatformKeys, it supports setting multiple keys and then matching a key data object to the correct one. This is to support the possibility of changing this key during reprovisioning (ie, as part of factory reset), where there would need to exist 2 keys (the old and new one) temporarily - this would prevent against loss of data if the process was interrupted at any point.
chrisccoulson
force-pushed
the
add-plainkey-platform
branch
from
72c15d7 to
0d14824
Compare
pedronis
reviewed
Mar 14, 2024
| * | ||
| */ | ||
|
|
||
| package plainkey |
There was a problem hiding this comment.
it would be good to have a doc comment for the package here.
probably a good idea to add one also for tpm2 at some point
There was a problem hiding this comment.
I've added a comment here now.
plainkey/platform.go
Outdated
| // AddPlatformKeys adds keys that will be used by this platform to recover other | ||
| // keys. These are typically stored in and loaded from an encrypted container that is | ||
| // unlocked via some other mechanism. | ||
| func AddPlatformKeys(keys ...[]byte) { |
There was a problem hiding this comment.
do we need this? anyway it seems not to be tested atm
There was a problem hiding this comment.
I've removed this.
| Version int `json:"version"` | ||
| Nonce []byte `json:"nonce"` | ||
|
|
||
| PlatformKeyID platformKeyId `json:"platform-key-id"` |
There was a problem hiding this comment.
it would be good to have a doc comment on this one
There was a problem hiding this comment.
I added a comment here.
I added a comment for the Nonce field as well and then realized it didn't make sense because the field was holding 2 unrelated values. I've pushed another change that splits this into 2 distinct fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This platform provides a way to unlock an encrypted container using a
key recovered from unlocking another container, and is suitable when
access to one encrypted container implies access to another one.
The intention of this is to replace the existing mechanism for unlocking
the save partition in run mode with something that uses a proper keyslot.
Keys are protected with a "platform key" - this is the key that is
stored in the first encrypted container. For the intended use case,
this key is stored inside the data partition, and then loaded by
snap-bootstrap, which should call plainkey.SetPlatformKeys before
unlocking the save partition.
Although normally there will only be a single key supplied to
SetPlatformKeys, it supports setting multiple keys and then matching
a key data object to the correct one. This is to support the possibility
of changing this key during reprovisioning (ie, as part of factory
reset), where there would need to exist 2 keys (the old and new one)
temporarily - this would prevent against loss of data if the process
was interrupted at any point.