efi: Prepare to add pre-install detection #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds profiles for PCR0 (platform firmware) and PCR2 (host firmware that runs from adapter cards or firmware that runs on embedded controllers)
This changes a few types, replaces pcrProfileFlags with pcrFlags and introduces a PCRProfileEnablePCRsOption interface which is implemented by the existing profile options and will be implemenented by a new composite option returned by the detection code.
chrisccoulson
force-pushed
the
efi-prepare-pre-install-detection
branch
from
b58c3fb to
9779ab1
Compare
|
Closing this one - it wasn't refreshing when I was pushing updates to it because it's a PR from a snapcore branch (which I don't normally create) rather than a branch in my own repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Currently draft because it depends on #299)
This changes a few types, replaces pcrProfileFlags with pcrFlags
and introduces a PCRProfileEnablePCRsOption interface which is
implemented by the existing profile options and will be implemenented by
a new composite option returned by the detection code.