preinstall: move some extra TPM tests to only run during pre-install #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
preinstall-skip-some-tpm-tests-post-install
branch
from
0c2598b to
e0c45dc
Compare
chrisccoulson
force-pushed
the
preinstall-skip-some-tpm-tests-post-install
branch
from
e0c45dc to
e3f1bc2
Compare
chrisccoulson
force-pushed
the
preinstall-skip-some-tpm-tests-post-install
branch
from
e3f1bc2 to
4701bb5
Compare
We were already skipping the lockout hierarchy auth value test during post-install because this doesn't make sense, but also skip similar tests for other hierarchies and also skip the lockout checkout and the test for sufficient number of NV counters.
chrisccoulson
force-pushed
the
preinstall-skip-some-tpm-tests-post-install
branch
from
4701bb5 to
5378ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RunChecksAPI will support being executed post-install eventhough it's primarily a pre-install API. A use case for this is re-running
it as part of the post-recovery repair process. Not all tests makes sense
post-install, unless a motherboard (and TPM) change was the reason for
recovery, and so are skipped.
We were already skipping the lockout hierarchy auth value test during
post-install because this doesn't make sense, but also skip similar
tests for other hierarchies and also skip the lockout checkout and the
test for sufficient number of NV counters.