internal/luks2/cryptsetup.go: use --help output to check for --replace-token #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-token Because --replace-token is now required for installation, we need to backport this feature to 20.04. That is on cryptsetup 2.2.2. However that version of cryptsetup does not support --test-args. So instead we look at the output of --help.
valentindavid
added a commit
to valentindavid/snapd
that referenced
this pull request
Oct 14, 2024
valentindavid
added a commit
to valentindavid/snapd
that referenced
this pull request
Oct 15, 2024
valentindavid
added a commit
to valentindavid/snapd
that referenced
this pull request
Oct 15, 2024
valentindavid
added a commit
to valentindavid/snapd
that referenced
this pull request
Oct 16, 2024
|
This is not a hight priority right now as we will deploy key datas in tokens only for core24+ for now. |
|
Closing for now. We will not use on 20 and 22 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because --replace-token is now required for installation, we need to backport this feature to 20.04. That is on cryptsetup 2.2.2. However that version of cryptsetup does not support --test-args. So instead we look at the output of --help.