tpm2: Use tpm2.TPMDevice abstraction #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
tpm2-use-tpm-device
branch
3 times, most recently
from
52a2864 to
382a512
Compare
Secboot currently opens a transport to the Linux character device at a hardcoded path (/dev/tpm0) and passes the opened transport to the deprecated tpm2.NewTPMContext API. The replacement API (tpm2.OpenTPMDevice) makes use of a new abstraction (tpm2.TPMDevice). The linux sub-package provides a way of enumerating TPM devices or providing access to the default one. It also provides access to the resource managed device, which we might want to use in secboot in the future, and it provides access to the physical presence interface for performing actions that are implemented in platform firmware. Implementing this now is required to write test cases for canonical#353, as the current test harness will permit the code under test to open as many TPM connections as it likes, when in reality, it can only have a single open connection if it is using the direct character device (/dev/tpm0).
chrisccoulson
force-pushed
the
tpm2-use-tpm-device
branch
from
382a512 to
fd69e5b
Compare
This was referenced Jan 9, 2025
chrisccoulson
added a commit
to chrisccoulson/secboot
that referenced
this pull request
Jan 16, 2025
PR canonical#357 migrated the tpm2 code to using the new tpm2.TPMDevice abstraction for opening TPM connections. The go-tpm2 package contains some other deprecated APIs, and in some cases, entire packages have been deprecated (crypto, templates, util). These have been replaced by alternative APIs, and ithe util package, which was a bit of a dumping ground for APIs that had nowhere else to go, has been split into more focused packages. This ports secboot to using updated APIs. It's just a straight port for now - we may want to refactor some code to make better use of these APIs in future PRs.
chrisccoulson
added a commit
that referenced
this pull request
Jan 17, 2025
…-go-tpm2-apis tpm2: Stop using deprecated go-tpm2 APIs. PR #357 migrated the tpm2 code to using the new tpm2.TPMDevice abstraction for opening TPM connections. The go-tpm2 package contains some other deprecated APIs, and in some cases, entire sub-packages have been deprecated (crypto, templates, util). These have been replaced by alternative APIs, and the util package, which was a bit of a dumping ground for APIs that had nowhere else to go, has been split into more focused packages. This ports secboot to using updated APIs. It's just a straight port for now - we may want to refactor some code to make better use of these APIs in future PRs - particularly those in the `policyutil` sub-package, something that will allow us to create keys with arbitrary policies without having to change the key data format for tpm2 keys (see issue #350).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secboot currently opens a transport to the Linux character device at a hardcoded path (/dev/tpm0) and passes the opened transport to the deprecated
tpm2.NewTPMContextAPI. The replacement API (tpm2.OpenTPMDevice) makes use of a new abstraction (tpm2.TPMDevice).The
linuxsub-package provides a way of enumerating TPM devices or providing access to the default one. It also provides access to the resource managed device, which we might want to use in secboot in the future, and it provides access to the physical presence interface for performing actions that are implemented in platform firmware.Implementing this now is required to write test cases for #353, as the current test harness will permit the code under test to open as many TPM connections as it likes, when in reality, it can only have a single open connection if it is using the direct character device (/dev/tpm0).