Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows promoting the charm for arm64 arch #245

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented Sep 17, 2024

Description

Allows promoting the charm for arm64 arch, adds an arch selection.
Depends on #242

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@saltiyazan saltiyazan requested a review from a team as a code owner September 17, 2024 09:47
@kayra1
Copy link
Contributor

kayra1 commented Sep 20, 2024

the integration tests are still not passing for some reason

@saltiyazan
Copy link
Contributor Author

the integration tests are still not passing for some reason

They will once #242 is merged, the fix is there. I can extract it and bring it here or in a separate PR if the review there takes longer.

@saltiyazan saltiyazan merged commit b7e8fa9 into main Sep 26, 2024
12 checks passed
@saltiyazan saltiyazan deleted the promote-arm64 branch September 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants