Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add stale issue handler action #338

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

jssotomdz
Copy link
Contributor

Quick draft on how the action could look like.
Found this suggestion about marking them as stale if open without any activity for 30 days and closing in another 30 days. This way we could "warn" both the opener and us to reply in case something is stuck and they/we have new info to discuss.

Also, Tim talked about the possibility of not affecting existing issues. Is that something I should include in this draft?

@jssotomdz jssotomdz requested review from tim-hm and ashuntu November 21, 2023 18:34
@ashuntu
Copy link
Collaborator

ashuntu commented Nov 21, 2023

My personal opinion is that it would probably be a good idea to start this from now on, and not be retroactive. The reason being that old issues haven't been "maintained" to the new standard that we are targeting, so it's not entirely fair to close them automatically. We should go through old issues manually and make sure they're actually stale.

I also still don't feel amazing about closing issues that aren't actually resolved (labels are fine), but that's for later discussion perhaps. Maybe we need a label that we can add to forcibly keep issues open?

@jssotomdz
Copy link
Contributor Author

Ok, added the start date parameter as today commented out. When we agree on the rest of the stuff (in case we still need to discuss something), I'll update it with that day's date, uncomment and remove the draft from the PR

Copy link

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ashuntu in that we should apply this going forward and not retroactively. I also agree that we need to keep discussing how to manage issues that don't have a clear resolution ... I would love for there to be a clear path for how we should approach them. Maybe if we had a tag, that when applied, the issue becomes excempt? Additionally, we should ask for community feedback.

One nit bit on the commit message. Typically you want to limit the subject line to 50 characters and the body to 72 characters as this ensures wide reability. For example the current subject is truncated:

image

How about something like: ci: add stale issue handler action

.github/workflows/autoclose.yml Outdated Show resolved Hide resolved
.github/workflows/autoclose.yml Show resolved Hide resolved
.github/workflows/autoclose.yml Outdated Show resolved Hide resolved
.github/workflows/autoclose.yml Outdated Show resolved Hide resolved
@jssotomdz jssotomdz changed the title actions(github): add github actions to mark stale issues and close abandoned issues ci: add stale issue handler action Nov 22, 2023
@jssotomdz jssotomdz marked this pull request as ready for review November 29, 2023 18:27
@jssotomdz jssotomdz merged commit cd652f7 into canonical:main Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants