Adds a type hint back to faults.py

canonical · Dec 12, 2023 · 96ab78b · 96ab78b
1 parent 79d33e6
commit 96ab78b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.github/workflows/terraform_test_deploy.yml b/.github/workflows/terraform_test_deploy.yml
@@ -47,10 +47,14 @@ jobs:
       - name: Set up microk8s
         uses: canonical/certification-github-workflows/.github/actions/microk8s-setup@main
 
+      # TODO: Separate this build step to its own action once custom VM images are available
+      # (when there is a charmcraft + LXD capable image available)
       - name: Build API charm
         run: charmcraft pack
         working-directory: ./backend/charm
 
+      # TODO: Separate this build step to its own action once custom VM images are available
+      # (when there is a charmcraft + LXD capable image available)
       - name: Build frontend charm
         run: charmcraft pack
         working-directory: ./frontend/charm

diff --git a/backend/charm/src/faults.py b/backend/charm/src/faults.py
@@ -1,7 +1,10 @@
+from typing import Optional
+
+
 class UnitReadinessFault:
     """A ReadinessFault describes the reason for a unit not to be ready."""
 
-    def __init__(self, reason: str, parent=None):
+    def __init__(self, reason: str, parent: "Optional[UnitReadinessFault]" = None):
         self.reason = reason
         self.parent = parent