Fix snap promotion #240
Merged
Fix snap promotion #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
approved these changes
Jan 9, 2025
| risk: str | ||
| risk: Literal[StageName.edge] | Literal[StageName.beta] | Literal[ | ||
| StageName.candidate | ||
| ] | Literal[StageName.stable] |
There was a problem hiding this comment.
Minor/optional comment, I think you can also specify this as something like:
Literal[StageName.edge, StageName.beta, StageName.candidate, StageName.stable]
Or even set something like:
ValidSnapStages = Literal[StageName.edge, StageName.beta, StageName.candidate, StageName.stable]
...
risk: ValidSnapStages
...
There was a problem hiding this comment.
Oh I didn't know that Literal could take multiple values. I was thinking of using the second approach but I'll delay it to my next PR that should include images as otherwise there will be some merge conflicts
Yeah that happens because typically a newer version pops up in the risk it was previously at. So TO would grab the next available channel map that is in a higher risk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a snap is available in more than one risk at a time (e.g. edge and beta) TO sets it's stage to the first risk it sees instead of the highest one. This PR fixes the bug.
Resolved issues
Fixes https://warthogs.atlassian.net/browse/RTW-426
Documentation
Web service API changes
Tests
Added bug as a test case.