Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow end test by test execution id #243

Closed
wants to merge 1 commit into from

Conversation

rpbritton
Copy link
Collaborator

@rpbritton rpbritton commented Jan 13, 2025

Description

Updates the /end-test endpoint to accept a test execution id. I figure this is worth while now that test executions are not unique on their ci_link.

Changes are backwards compatible.

Resolved issues

SQT-430

Documentation

N/A?

Web service API changes

/end-test must have one of (and only one of) test execution id or ci link.

Tests

Unit tests added to test the additional argument.

@rpbritton rpbritton requested a review from omar-selo January 13, 2025 20:46
@rpbritton
Copy link
Collaborator Author

Actually /{id}/end-test makes more sense for this.

@rpbritton rpbritton closed this Jan 13, 2025
@omar-selo
Copy link
Collaborator

Actually /{id}/end-test makes more sense for this.

You're right, we're deprecating /end-test endpoint anyways in favor of POST /id/test-results and PATCH /id

@rpbritton rpbritton deleted the add/end-test-by-test-execution-id branch January 15, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants