Add image testing backend #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
worth noting that I tried to create an abstract Artefact class that each family subclasses from (Snap, Deb, Image, Charm). But that ended up creating a huge change and in many places separate logic that could be grouped together. I decided to remove that change |
omar-selo
force-pushed
the
add-image-testing-backend
branch
from
d5dcc08 to
25bd3e5
Compare
rpbritton
reviewed
Jan 15, 2025
| "name", | ||
| "version", | ||
| "track", | ||
| postgresql_where=column("family") == FamilyName.charm.name, |
There was a problem hiding this comment.
This is nice, I was trying to do this when adding charms but can't remember why it was causing me grief, something to do with trying to join another table. Was family moved?
rpbritton
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds backend changes required for image artefact family.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-301
Documentation
Web service API changes
Endpoints that return Artefacts now additionally include keys specific to images. This is however not a breaking changes to existing clients.
Tests
Added some tests and updated others