Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-5833 Ranger group management #21

Merged
merged 16 commits into from
Oct 24, 2023

Conversation

AmberCharitos
Copy link
Contributor

Update to Ranger relation, takes the configuration string provided by the Ranger relation and uses it to synchronize Unix users and group membership. Related to canonical/ranger-k8s-operator#14 and spec CS-116

Copy link

@kelkawi-a kelkawi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments. Are there any integration tests that can be added to validate this?

src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
Copy link

@mertalpt mertalpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Handle style comments however you like.

src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions to reduce a bit the code

src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks much better, just one last comment

src/relations/policy.py Outdated Show resolved Hide resolved
@AmberCharitos AmberCharitos requested a review from gtato October 20, 2023 10:21
Copy link
Contributor

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetics comments

src/relations/policy.py Outdated Show resolved Hide resolved
src/relations/policy.py Show resolved Hide resolved
@AmberCharitos AmberCharitos requested a review from gtato October 23, 2023 15:22
@AmberCharitos AmberCharitos merged commit 78863a2 into main Oct 24, 2023
@gtato gtato deleted the CSS-5833-trino-ranger-group-management branch September 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants