Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate public charm listing suggestions #25

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

AmberCharitos
Copy link
Contributor

Incorporates suggestions from review as seen here: #24

CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments, nothing critical

.github/workflows/integration_test.yaml Outdated Show resolved Hide resolved
src/relations/policy.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@AmberCharitos AmberCharitos merged commit 13b3899 into main Nov 30, 2023
12 checks passed
@gtato gtato deleted the public-listing-suggestions branch September 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants