-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #176
Update dependencies #176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 13 13
Lines 3504 3504
=======================================
Hits 3155 3155
Misses 311 311
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, none of those seem particularly ominous. Should we also bump the snapcraft.yaml version before merging? (The +snapX version so people know this one has some actual changes). Please either merge as-is or bump the version and then merge. Thanks!
3462966
to
adf3243
Compare
This is failing to build with snapcraft. I only partially updated dependencies because canonical/snapd#13339 was not ready but since this should soon be merged, I will wait and use the last version of snapd to test everything is building properly. |
Hey @upils ! Is this still blocked on the snapd PR that you mentioned? |
adf3243
to
e00496c
Compare
e00496c
to
109ce6c
Compare
@sil2100 spread tests are failing (temporary unrelated failure) but otherwise this looks good. I now use the go snap instead of the package to use a more recent version without having to mess with PATH and to be coherent with our tests. In the end the main goal of this PR (fix some vulnerabilities in our dependencies) is also reached. |
Update various dependencies, initially to solve a security issue in one of them.