Set gpt partition as bootable if associated to system-boot role #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 18 18
Lines 3429 3431 +2
=======================================
+ Hits 3222 3224 +2
Misses 133 133
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
upils
force-pushed
the
set-gpt-partition-bootable
branch
from
4689e4d to
64ef73a
Compare
sil2100
reviewed
Jun 18, 2024
And NOW I remember what was missing on this PR! :D I did some manual tests but you are right, I can surely write a test for that, or at least add a check on one of our "full run" tests. |
upils
force-pushed
the
set-gpt-partition-bootable
branch
from
64ef73a to
5b85d23
Compare
upils
force-pushed
the
set-gpt-partition-bootable
branch
from
5b85d23 to
546e6ab
Compare
Signed-off-by: Paul Mars <[email protected]>
upils
force-pushed
the
set-gpt-partition-bootable
branch
from
546e6ab to
4358120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure gpt partitions associated to a system-boot role have the bootable attribute set. This was missing and was problematic because uboot failed to find the partition to boot on.
Fixes FR-8056