Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #113

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Update dependencies #113

merged 7 commits into from
Feb 4, 2025

Conversation

jpike88
Copy link
Contributor

@jpike88 jpike88 commented Nov 1, 2024

No description provided.

@stewones
Copy link
Member

stewones commented Nov 1, 2024

hey @jpike88 can yo check these conflicts?

Copy link
Contributor

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks build, lint and fmt npm scripts.
Also breaks the iOS build because Intercom 18 requires iOS 15 but the plugin supports iOS 13+.
Updating the Android dependencies is a breaking change, doesn't break the build, but should be taken into consideration for doing a major version bump if this PR gets merged.

@stewones
Copy link
Member

stewones commented Nov 2, 2024

good catch, thanks for checking @jcesarmobile
consumers can always override the version in their client, so do we really want these changes in the first place?

@jpike88
Copy link
Contributor Author

jpike88 commented Nov 4, 2024

I've fixed and addressed all above concerns I could find, thoughts?

@jpike88
Copy link
Contributor Author

jpike88 commented Nov 5, 2024

I forked and tested on both android and iOS, seems fine

@stewones
Copy link
Member

could you take a peak @jcesarmobile ?

@jpike88 jpike88 force-pushed the master branch 2 times, most recently from 0e4b3ee to 3a75de5 Compare January 20, 2025 06:19
@jpike88
Copy link
Contributor Author

jpike88 commented Jan 20, 2025

Two months later............

@stewones
Copy link
Member

stewones commented Feb 2, 2025

Two months later............

sorry for delay @jpike88 but unfortunately that's how open source works.
can you please rebase again? I promise to try and have a look this week

thank you.

@jpike88
Copy link
Contributor Author

jpike88 commented Feb 3, 2025

resolved conflict, ready to look at

@stewones
Copy link
Member

stewones commented Feb 4, 2025

LGTM thanks @jpike88

@stewones stewones merged commit 2404db4 into capacitor-community:master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants