fix(firestore): handle snapshot errors on web (#655)

* fix(firestore): handle snapshot errors on web * add the changeset * Update itchy-cobras-hunt.md --------- Co-authored-by: Robin Genz <[email protected]>
capawesome-team · Jun 27, 2024 · 841d9d3 · 841d9d3
1 parent ce5c1d4
commit 841d9d3
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 20 deletions.
diff --git a/.changeset/itchy-cobras-hunt.md b/.changeset/itchy-cobras-hunt.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/firestore': patch
+---
+
+fix(web): handle snapshot errors
diff --git a/packages/firestore/src/web.ts b/packages/firestore/src/web.ts
@@ -221,6 +221,7 @@ export class FirebaseFirestoreWeb
         };
         callback(event, undefined);
       },
+      error => callback(null, error),
     );
     const id = Date.now().toString();
     this.unsubscribesMap.set(id, unsubscribe);
@@ -237,16 +238,20 @@ export class FirebaseFirestoreWeb
       options,
       'collection',
     );
-    const unsubscribe = onSnapshot(collectionQuery, snapshot => {
-      const event: AddCollectionSnapshotListenerCallbackEvent<T> = {
-        snapshots: snapshot.docs.map(documentSnapshot => ({
-          id: documentSnapshot.id,
-          path: documentSnapshot.ref.path,
-          data: documentSnapshot.data() as T,
-        })),
-      };
-      callback(event, undefined);
-    });
+    const unsubscribe = onSnapshot(
+      collectionQuery,
+      snapshot => {
+        const event: AddCollectionSnapshotListenerCallbackEvent<T> = {
+          snapshots: snapshot.docs.map(documentSnapshot => ({
+            id: documentSnapshot.id,
+            path: documentSnapshot.ref.path,
+            data: documentSnapshot.data() as T,
+          })),
+        };
+        callback(event, undefined);
+      },
+      error => callback(null, error),
+    );
     const id = Date.now().toString();
     this.unsubscribesMap.set(id, unsubscribe);
     return id;
@@ -262,16 +267,20 @@ export class FirebaseFirestoreWeb
       options,
       'collectionGroup',
     );
-    const unsubscribe = onSnapshot(collectionQuery, snapshot => {
-      const event: AddCollectionSnapshotListenerCallbackEvent<T> = {
-        snapshots: snapshot.docs.map(documentSnapshot => ({
-          id: documentSnapshot.id,
-          path: documentSnapshot.ref.path,
-          data: documentSnapshot.data() as T,
-        })),
-      };
-      callback(event, undefined);
-    });
+    const unsubscribe = onSnapshot(
+      collectionQuery,
+      snapshot => {
+        const event: AddCollectionSnapshotListenerCallbackEvent<T> = {
+          snapshots: snapshot.docs.map(documentSnapshot => ({
+            id: documentSnapshot.id,
+            path: documentSnapshot.ref.path,
+            data: documentSnapshot.data() as T,
+          })),
+        };
+        callback(event, undefined);
+      },
+      error => callback(null, error),
+    );
     const id = Date.now().toString();
     this.unsubscribesMap.set(id, unsubscribe);
     return id;